Multiple modules load error

[mort3za]

In version 0.2.0 calling this works good:

$ocLazyLoad.load([
  {name: 'module_name1', files: ['path/to/module1.js']},
  {name: 'module_name2', files: ['path/to/module2.js']},
]);

but in latest version throws exception. i use angular.js 1.2.14

[TimNZ]

+1, broken in 0.3.0

[ocombe]

Ok, do you have the message of the exception ?
Do you use the internal js loader, requirejs or script.js ?
Are module1 and module2 independant or do one of them require the other one ?

[mort3za]

unfortunately i can't see that situation again and i didn't saved it but i am sure changing plugin file was source of error.
error was something like module undefined is not available... seemed it was related to name of modules.

[TimNZ]

In my case I simply replaced 0.2.0 with 0.3.0 and it started failing.

Since I'm on a time crunch with a project I reverted to 0.2.0, and since 0.2.0 works I don't have a compelling reason to actually upgrade to 0.3.0, I'll have another look after release in a week or so.

[ocombe]

Ok thanks !

[ocombe]

You should check if it was the same bug as #33 fixed in release 0.3.1

[TimNZ]

Still broken.

The files are being loaded but do not appear to be evaluated/executed properly.

Still in the middle of prep for release so won't look at it again till at least next week, thankfully 0.2.0 works fine.

[ocombe]

Damn :-(

[taz]

I've spent a bit of time looking at this and the only place I could reproduce any sort of error was using IE in ie8 emulation mode, where it kicked up a stink about the trailing comma in the original post.

I'm sceptical as to whether that's the actual problem though or just an issue with the example given. It didn't occur in 0.2.0 though, only 0.3.0, so you never know!

Either way, I've put in a quick fix to handle when the module being passed to the loader is undefined or null. I'm still testing a couple of other bits, then I'll issue a PR.

[ocombe]

Awesome, thanks ! Take your time, we're all doing this for the community. Thanks again for your help.

[ocombe]

@TimNZ & @mort3za can you try the current master (it's not a release yet) and see if the PR from @BenBlazely fixes your problems ?