Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistency between Handle and ReaderHandle #84

Open
oconnor663 opened this issue May 28, 2020 · 2 comments
Open

inconsistency between Handle and ReaderHandle #84

oconnor663 opened this issue May 28, 2020 · 2 comments

Comments

@oconnor663
Copy link
Owner

The latter kills on drop, the former doesn't. That seems like a pretty bad inconsistency. Maybe Handle should kill on drop too?
@oconnor663
Copy link
Owner Author

Actually, it would probably be better for both to use a background thread to wait. Maybe we could avoid the implicit killing entirely.

@oconnor663
Copy link
Owner Author

Would it make sense to take a similar approach to partially started pipelines? Killing processes is gross. We could spawn a background thread to wait for the left half to exit on its own, which should be prompt in the vast majority of cases because of SIGPIPE or similar. (Or do nothing on Windows as an optimization, since zombies aren't a concern there, but probably no one cares about the thread.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oconnor663