ImGui text editor with all the gems -- discussion etc.

[ChemistAion]

@vdweller84 @slajerek @dfranx @arabine @santaclose @slajerek @justinbowes @shakfu
...and ofc @BalazsJako

Let's collect here all the ideas and approaches regarding the Editor thing... similarly to NodeEditor #306
No credits to me, I've @dfranx fork (https://github.com/BalazsJako/ImGuiColorTextEdit) with "all" the bugs fixed:
https://github.com/ChemistAion/ImTextEdit

@ocornut: ...waiting for your blessing, to move IT from Gallery

[ocornut]

Hello,
I am not sure we particularly need an extra thread for this,
But please post your link under BalazsJako's one in https://github.com/ocornut/imgui/wiki/Useful-Extensions#text-editors for visibility? I occasionally post them again in release notes.

waiting for your blessing, to move IT from Gallery

I'm not sure I understand what you mean? blessing for what?

[LucLoubat]

Hi,
Just to flag that this version of the TextEditor won't work as is.
It is tight with SDL and use the legacy SDL_ScanCode for all keys related logic.
And there is a dependency need with SpvGenTwo for the SPIR-V language wicth is deeply implemented in the TextEditor.
Clear all this is just very annoying and burn the benefice of "all the bugs fixed".

[slajerek]

Thanks. This reminds me that I still haven't found any reliable, simple but also reasonably elegant text editor for ImGui... I've given a pass on this one long time ago when I spent literally whole evening trying to fix bugs and the list was endless. Anyway, any available text editors for ImGui that I am not aware of?

[ChemistAion]

@LucLoubat, @slajerek

Here is @BalazsJako ImGuiColorTextEdit widget improved by @dfranx patches with some mods (e.g.: SPIR-V removed on my madX branch), enjoy: https://github.com/ChemistAion/ImTextEdit

@dfranx IMHO is the most advanced progression: https://github.com/dfranx/ImGuiColorTextEdit

Here are others: https://techgaun.github.io/active-forks/index.html#https://github.com/BalazsJako/ImGuiColorTextEdit

[LucLoubat]

Hi @ChemistAion,
Sorry, i was forget to take look at the branches on your depo.
Thanks a lot for this additional notes and the other links, it is appreciate.

[LucLoubat]

@ChemistAion,
Sorry if i don't understand.

In your madX branch the SPIR-V continue to be in use and SPIRVParser.cpp just fail.
The #include "spvgentwo/Spv.h" is comment out but the complete code continue to have all the ref to spvgentwo::spv everywhere in it.
This simply don't work.

Also, the #include "_editor.hpp" at line 9 in the ImTextEdit.cpp.
This fail to.
Do the file is needed ?
Because it is missing.

What do i miss ?

note :
The TextEditor from "santaclose" referenced in the other links you mention, just run at first try.
It look's less features complete and i need more investigations to know if all the supposed features describe in the github page works, but at least the code don't fail.

[ChemistAion]

@LucLoubat:
Ohh...
I will check what's wrong there then (my branch).
I haven't worked with it in a while, but I'm pretty sure that "spvgentwo::spv" was the first thing I removed (or "disabled").
Perhaps there are some missing pushes; I will clean it up.

Give me one day tops - I need some time to switch back there.

btw:
I've just checked, and it appears that @dfranx hasn't made any further changes since I last worked on it, which was about 2-3 years ago. At that time, this was the most advanced progress on @BalazsJako's base, when he 'left' it for others to take over:
BalazsJako/ImGuiColorTextEdit#128

[LucLoubat]

Hi @ChemistAion,
Thx for the answer.

Yes i know the BalazsJako original one with limited functionalities but simple and fully functional.
It is the one i use as base to my version in which i have simply added Python in the language definition.

For sure i was interested with the dfranx version that add so much functionalities, but it is full of dependencies and so on.

It will be awesome if your vesion bring a light in this domain.
So thx, i am looking around for your cleaned version :)

[ChemistAion]

Hi @LucLoubat,
I just did a quick run on it (my madX branch) and indeed, this version requires SpvGenTwo to be available within the project for auto-completion and tool-tips as additional functionalities.

I've looked around but couldn't find the mentioned one with SpvGenTwo stripped down... 😕
...sadly, I also can't just jump into it at the moment and remove these features on "demand", meaning to cut off SpvGenTwo dependency (I like auto-completion and tool-tips, so I want to keep it as-is) 😅

I will leave you with these suggestions for now:

• just add SpvGenTwo and you will get super nice tool-tips and auto-completion for GLSL and HLSL 😇
• remove auto-completion containers and the code references to it - then SpvGenTwo will be also out (one afternoon tops, slow pace):
  https://github.com/ChemistAion/ImTextEdit/blob/81ec756b5627dd351fe0dac26a7403982349df68/ImTextEdit.h#L454-L457

In regards of missing _editor.hpp - you could remove it, this is a PCH leftover.

[LucLoubat]

Hi @ChemistAion
Thx for the answer and your time.
Well, it look's like a back to the starting point to me.