Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Unbound value #695

Closed
bguil opened this issue Jul 18, 2021 · 4 comments · Fixed by #715
Closed

Error: Unbound value #695

bguil opened this issue Jul 18, 2021 · 4 comments · Fixed by #715

Comments

@bguil
Copy link

bguil commented Jul 18, 2021

With the following code in file test.eliom:

let _ = Eliom_request_info.get_original_filename

The command eliomc -ppx -infer test.eliom works nicely with eliom 7.0.0 but fails with eliom 8.4.8

eliom.7.0.0

  • opam list | grep eliom
eliom                         7.0.0        Client/server Web framework
  • eliomc -ppx -infer test.eliom

eliom.8.4.8

  • opam list | grep eliom
eliom                         8.4.8        Client/server Web framework
  • eliomc -ppx -infer test.eliom
File "test.eliom", line 1, characters 8-48:
1 | let _ = Eliom_request_info.get_original_filename
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Eliom_request_info.get_original_filename

NB: I've observed the same problem on two different installation: Ocaml version 4.08.1 on Linux and Ocaml version 4.11.1 on MacOSX.

@bguil
Copy link
Author

bguil commented Sep 12, 2021

Just a ping on this uncommented issue. Any news about it?

@balat
Copy link
Member

balat commented Sep 13, 2021

Indeed the function disappeared during the switch to cohttp.
By mistake I suppose or is there a reason @vasilisp ?
The information seems to be easily available https://github.com/ocsigen/ocsigenserver/blob/master/src/server/ocsigen_extensions.mli#L37
I suggest we put back the missing functions ...

@balat
Copy link
Member

balat commented Sep 14, 2021

@balat
Copy link
Member

balat commented Sep 17, 2021

Merged

@balat balat closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants