Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot to add fix NOT_AVAILABLE stub code for Lwt_unix.send_msgto to 5.4.1 #868

Closed
MisterDA opened this issue Jun 7, 2021 · 2 comments
Closed

Comments

@MisterDA
Copy link
Contributor

MisterDA commented Jun 7, 2021

IIUC commit 5ffe09f fix NOT_AVAILABLE stub code for Lwt_unix.send_msgto is a bug fix on Windows that add noop symbols for functions introduced in 20e8836 lwt.unix: add Lwt_unix.send_msgto that takes a destination address. I f the commit isn't present it leads to link failure on Windows, as happens with ocaml-community/utop#356. The bug-fix wasn't included in the 5.4.1 release.
I'd suggest releasing a 5.4.2 with this patch ;)

Error: Error while linking C:\\Users\\antonin\\.opam\\ocaml-variants.4.12.0+mingw64c\lib\lwt\unix/lwt_unix.cma(Lwt_unix):
       The external function `lwt_unix_send_msg_byte' is not available
@MisterDA MisterDA changed the title Forgot to add _fix NOT_AVAILABLE stub code for Lwt_unix.send_msgto_ to 5.4.1 Forgot to add fix NOT_AVAILABLE stub code for Lwt_unix.send_msgto to 5.4.1 Jun 7, 2021
@raphael-proust
Copy link
Collaborator

I have pushed a 5.4.2 branch with this fix. I'll release next week. Thanks for the bug-report.

@raphael-proust
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants