Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Use a proper vendor override for default desktop settings #45

Open
moeenio opened this issue Sep 19, 2021 · 4 comments
Open

Use a proper vendor override for default desktop settings #45

moeenio opened this issue Sep 19, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@moeenio
Copy link
Contributor

moeenio commented Sep 19, 2021

AFAIK, currently, the custom desktop settings for CelOS are applied in two ways :

  • A login script applying some settings on first login
  • A gsettings vendor override for some other settings.

These solutions both have their problems :

  • The login script is fine but it doesn't feel very professional and is far from being the proper way to this.
  • Vendor override is the proper way, but it's still done improperly, as the settings are added to the 10-ubuntu-settings[...] file, which belongs to the upstream ubuntu-settings package, which means it might be overwritten by an update... and it certainly shouldn't be used for downstream settings anyway.

We should make our own vendor override file, with all the desktop settings in it. I have already messed with something like this.

@moeenio moeenio added enhancement New feature or request good first issue Good for newcomers labels Sep 19, 2021
@moeenio moeenio added this to the CelOS 1-beta7 milestone Sep 19, 2021
@moeenio moeenio pinned this issue Oct 9, 2021
@moeenio
Copy link
Contributor Author

moeenio commented Jan 17, 2022

Vendor override is the proper way, but it's still done improperly, as the settings are added to the 10-ubuntu-settings[...] file,

I am referring to this from README:

We have modified the file in "/usr/share/glib-2.0/schemas/10-ubuntu-settings.gschema.override" in order for our Adwaita Icons, Wallpaper, and Adwaita-dark shell theme to apply by default.

@moeenio
Copy link
Contributor Author

moeenio commented Apr 20, 2022

Have a look at this article for making a vendor override file. Settings relevant here should be found within /org/gnome in dconf-editor.

@TheOceanBreeze
Copy link
Member

See this article for information about Ubuntu adding color options to Gnome: https://ubuntuhandbook.org/index.php/2022/03/gnome-42-released-ubuntu-2204-desktop/

@moeenio
Copy link
Contributor Author

moeenio commented May 21, 2022

This article does not really give any useful technical information. It would however be good to consider how we can make our theme choice and these new theme settings work together.

As far as I can recall the different accent colors are just global GTK stylesheets.

Things to research :

  • I thought that there wouldn't be GTK4 apps in this version of Ubuntu, however that's not what this article is saying. Although whether or not Ubuntu is including some, we inevitably will, through Flatpak. I wonder what the accent color setting would do with GTK4+libadwaita apps (which do not follow the system theme) and especially Flatpaked ones.
  • How is the light/dark theme selector implemented? Does it choose between two global GTK stylesheets (and are these forcibly Yaru?), does it use the new Dark Style Preference , or does it do both?
  • How is this all stored and accessible in dconf?
  • Do these settings show up only on Ubuntu's downstream GNOME session, like the settings for the Dock do in 20.04, or do they show on the vanilla GNOME session (which we're using) as well? If they don't, all of the above problems are mostly solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants