Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: @octokit/action 5.0.3 has no type definition #493

Closed
1 task done
kitsuyui opened this issue May 13, 2023 · 2 comments · Fixed by #494
Closed
1 task done

[BUG]: @octokit/action 5.0.3 has no type definition #493

kitsuyui opened this issue May 13, 2023 · 2 comments · Fixed by #494
Assignees
Labels
released Type: Bug Something isn't working as documented

Comments

@kitsuyui
Copy link

kitsuyui commented May 13, 2023

What happened?

The npm package of @octokit/action 5.0.3 released does not contain type definition files.
The following shows the comparison with the files of 5.0.2.

5.0.2: https://www.npmjs.com/package/@octokit/action/v/5.0.2?activeTab=code
5.0.3 https://www.npmjs.com/package/@octokit/action/v/5.0.3?activeTab=code

5-0-2-dist-node 5-0-2 5-0-3-dist-node 5-0-3

Versions

@octokit/action 5.0.3

Relevant log output

Since there is no type definition, an error occurs during build.
The following is an example of a build in my project kitsuyui/happy-commit#95 .

import { Octokit } from '@octokit/action';

yarn run v1.22.19
$ ncc build src/index.ts --license licenses.txt
ncc: Version 0.36.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.0.4 (local user-provided)
Error: [tsl] ERROR in /home/yui/happy-commit/src/github.ts(2,25)
      TS7016: Could not find a declaration file for module '@octokit/action'. '/home/yui/happy-commit/node_modules/@octokit/action/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__action` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/action';`
[tsl] ERROR in /home/yui/happy-commit/src/github.ts(95,28)
      TS7006: Parameter 'commit' implicitly has an 'any' type.
[tsl] ERROR in /home/yui/happy-commit/src/index.ts(3,25)
      TS7016: Could not find a declaration file for module '@octokit/action'. '/home/yui/happy-commit/node_modules/@octokit/action/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__action` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/action';`
    at /home/yui/happy-commit/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1870077
    at /home/yui/happy-commit/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:383620
    at _done (eval at create (/home/yui/happy-commit/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:9:1)
    at eval (eval at create (/home/yui/happy-commit/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:34:22)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kitsuyui kitsuyui added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels May 13, 2023
@wolfy1339
Copy link
Member

I'll get right on it.

This is because of a breaking change in npm@9 and our build system being deprecated.

@wolfy1339 wolfy1339 self-assigned this May 13, 2023
@wolfy1339 wolfy1339 added Priority: High and removed Status: Triage This is being looked at and prioritized labels May 13, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active May 13, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active May 16, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants