Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JWT expiry #36

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Update JWT expiry #36

merged 2 commits into from
Jun 12, 2019

Conversation

mfix22
Copy link
Contributor

@mfix22 mfix22 commented Jun 12, 2019 •
edited
Loading

See probot/probot#942 for context

@gr2m
Copy link
Contributor

gr2m commented Jun 12, 2019

Could you update the tests, too:

app.js/test/index.test.ts

Lines 34 to 36 in 60ca3d9

// see https://runkit.com/gr2m/reproducable-jwt
const BEARER =
"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjAsImV4cCI6NjAwLCJpc3MiOjF9.UYfZtE742hkMV5cKMwp6-gVUvsWnUGoCQkl2UZZEkN8-lgvqzq5V8e5KtTrJxAAgcK7Yn1ViAlDUpwc9hZxrZ-gLaR10GR2hubte3OgkRDH-m_lCQ1Sgb9VQpZnagh_PMyRwphOw3uDXU3D7h2jL86UP3Ora8i9SRgXLq8X_2R9jtr2FDT1wtmcOLdyIc0Q7c_4X1uIPNjZS2UY04QBT7VWePk81EGdJAVQ_nEygXIuWOpMwZvtD0K1hzqQQM9GyV2QOwFSvFLtdbMVyld6Qvs8eEA5VS6Y4vTrGuyUF_lH5XlPdfAFAyrzsGP4inLq3tq6y4mjsx3YIF0P8DcMNPw";

gr2m
gr2m approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 9a8c2f2 into octokit:master Jun 12, 2019
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mfix22 mfix22 deleted the patch-1 branch June 12, 2019 21:15
@gr2m gr2m mentioned this pull request Jun 13, 2019
Closed
This was referenced Dec 9, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfix22 @gr2m @octokitbot