Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appId can now be set to the application's Client ID #603

Closed
1 task done
gr2m opened this issue May 2, 2024 · 2 comments · Fixed by #606
Closed
1 task done

appId can now be set to the application's Client ID #603

gr2m opened this issue May 2, 2024 · 2 comments · Fixed by #606
Assignees
@oscard0m
Labels
released Type: Feature New feature or request

Comments

@gr2m
Copy link
Contributor

gr2m commented May 2, 2024 •
edited
Loading

Describe the need

See gr2m/universal-github-app-jwt#98 and https://github.blog/changelog/2024-05-01-github-apps-can-now-use-the-client-id-to-fetch-installation-tokens/

universal-github-app-jwt has been updated accordingly in v2.2.0

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gr2m gr2m added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels May 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label May 2, 2024
@gr2m gr2m changed the title [FEAT]: appId can now. be set to the application's Client ID appId can now be set to the application's Client ID May 3, 2024
@oscard0m oscard0m self-assigned this May 8, 2024
@oscard0m oscard0m mentioned this issue May 8, 2024
Merged
4 tasks
@gr2m gr2m closed this as completed in #606 May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscard0m oscard0m

Labels
released Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: appId argument can be set to Client ID string octokit/auth-app.js
3 participants
@gr2m @oscard0m @wolfy1339