Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing types for OctokitOptions #150

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Add missing types for OctokitOptions #150

merged 3 commits into from
Aug 4, 2020

Conversation

sorenlouv
Copy link
Contributor

This PRs adds types for the options specified in the rest.js docs

Before:

After:

@gr2m gr2m added Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only labels Aug 4, 2020
gr2m
gr2m approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks a lot!

@gr2m gr2m merged commit 80ca4a1 into octokit:master Aug 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sorenlouv sorenlouv deleted the patch-1 branch August 9, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorenlouv @gr2m