Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert accidental breaking change in patch release #381

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jul 15, 2024

This reverts commit ed7d1b4.

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • The dependency glob was recently updated to v11, that version dropped support for Node versions lower than 20
  • Glob is used as a runtime dependency
  • Lack of an explicit engines field

After the change?

  • Reverts the update to glob to the previous version
  • Adds an explicit engines field

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jul 15, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit 0918c67 into main Jul 15, 2024
8 checks passed
@wolfy1339 wolfy1339 deleted the revert-glob branch July 15, 2024 13:00
@wolfy1339 wolfy1339 restored the revert-glob branch July 15, 2024 15:24
Copy link

🎉 This PR is included in version 8.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants