-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkg): add main
entry point
#551
Conversation
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [SFINT-5436](https://coveord.atlassian.net/browse/SFINT-5436) This rule was previously added because a new major version of `@octokit/graphql` broke our implantation in Quantic script that uses this dependency. This turned out to be an issue from their side that was fixed shortly after that new major version : octokit/graphql.js#551 Plus this renovate rules were containing a typo in the library name that prevented the rule from doing its job properly. we had `"matchPackagePatterns": ["^@otokit/graphql$"],` instead of `"matchPackagePatterns": ["^@octokit/graphql$"],` thus this dependency has been already updated by renovate to the latest version as you can see here: https://github.com/coveo/ui-kit/blob/1b28010482d0c88daf64aa98dae12f9a94a85c11/packages/quantic/package.json#L61-L62 [SFINT-5436]: https://coveord.atlassian.net/browse/SFINT-5436?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Sylvie Allain <58052881+sallainCoveo@users.noreply.github.com>
Some tools don't play well with only having the
exports
field present.See octokit/core.js#662