Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better type system for octokit.request() and API versions #39

Merged
merged 21 commits into from
Oct 5, 2021
Merged

feat: better type system for octokit.request() and API versions #39

merged 21 commits into from
Oct 5, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Sep 17, 2021

closes #38

@gr2m gr2m added Type: Feature New feature or request typescript labels Sep 17, 2021
gr2m added 20 commits September 19, 2021 13:15
@gr2m
WIP remove built-in support for GET / root endpoint
0659675
@gr2m
WIP remove support for unknown endpoint if REST API types are loaded
845d681
@gr2m
test: adapt for new type system
971ab62
@gr2m
fix: types-rest-api-*-compatible packages
089b20a
@gr2m
build: bump typescript to 4.4.3
b94470b
@gr2m
fix(types-rest-apighes-3.{0,1}): RemovedRoutes is now a union of al…
30f41a2 
…l routes that were removed in comparison to github.com, not only the next GHES version
@gr2m
test: adapt for new type system
65d335d
@gr2m
types: set correct version for octokit.request() when using `Extend…
64381fc 
…OctokitWith<Octokit<"ghes-3.0">, { ... }>`
@gr2m
test: make tsd happy when checking for octokit.options.version type
ffbd4ce
@gr2m
test(js/ghes-3.1): adapt for new types
b98376f
@gr2m
test(js/ghes-3.1-class): adapt for new types
4b84336
@gr2m
test(js/ghes-3.1-compatible): adapt for new types
4b02320
@gr2m
test(js/github.ae): adapt for new types
4ef1e2c
@gr2m
test(js/github.com): adapt for new types
b0197da
@gr2m
test(js/plugins-and-defaults): adapt for new types
5547110
@gr2m
test(js/request): adapt for new types
d370a2f
@gr2m
test(js/with-defaults-version): adapt for new types
a809c87
@gr2m
test(ts): adapt for new type system
8ae384c
@gr2m
test: GHES 3.2
50cffaa
@gr2m
types(rest-api*): only import what's used
5801306
@gr2m gr2m changed the title refactor: remove the never type for unsupported endpoints, require { request: { version }} to be set instead feat: better type system for octokit.request() and API versions Oct 5, 2021
@gr2m gr2m enabled auto-merge (squash) October 5, 2021 00:57
@gr2m gr2m merged commit b823214 into main Oct 5, 2021
@gr2m gr2m deleted the 38/new-type-system branch October 5, 2021 01:00
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Feature New feature or request typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the never type for unsupported endpoints, require { request: { version }} to be set instead
1 participant
@gr2m