Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the full functionality of @octokit/request in @octokit-next/request #41

Closed
4 tasks done
Tracked by #2127
gr2m opened this issue Oct 6, 2021 · 0 comments · Fixed by #69
Closed
4 tasks done
Tracked by #2127

implement the full functionality of @octokit/request in @octokit-next/request #41

gr2m opened this issue Oct 6, 2021 · 0 comments · Fixed by #69
Assignees

Comments

@gr2m
Copy link
Contributor

gr2m commented Oct 6, 2021

Including all of the README, tests, and whatever else is implemented in @octokit/request. Compare to https://github.com/octokit/octokit-next.js/tree/main/packages/endpoint

  • Move tests from https://github.com/octokit/request.js/ into /packages/request/test. Rewrite the tests from TS/Jest to JS/uvu
  • Add test, test:code, test:types scripts to the package.json
  • Add type tests to index.test-d.ts
  • Make sure RequestInterface includes the .endpoint APIs
@gr2m gr2m self-assigned this Oct 6, 2021
@gr2m gr2m linked a pull request Sep 27, 2022 that will close this issue
@gr2m gr2m closed this as completed in #69 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant