Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Support overriding github api url in create-github-app-token github action #2569

Closed
1 task done
harshtrivedi134 opened this issue Nov 6, 2023 · 2 comments
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request

Comments

@harshtrivedi134
Copy link

harshtrivedi134 commented Nov 6, 2023

Describe the need

Reference from discussion
I was creating an access token for a github app installed in a different organization and repository. I learned about https://github.com/actions/create-github-app-token#create-a-token-for-all-repositories-in-another-owners-installation.

Similar to the baseUrl option in Octokit constructor, it would be great if we could specify the github API url as an input to this action

      - uses: actions/create-github-app-token@v1
        id: get-access-token
        with:
          app-id: APP_ID
          private-key: PRIVATE_KEY
          base-url: https://slack-github.com/api/

I tried creating an access token for my github app installed in a different organization by specifying the owner and repository using the following:

      - uses: actions/create-github-app-token@v1
        id: get-access-token
        with:
          app-id: APP_ID
          private-key: PRIVATE_KEY
          owner: "owner"
          repositories: |
            owner/repo_name

However, the default github API hostname/url is set to api.github.com and we cannot change it to a custom hosted github installation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@harshtrivedi134 harshtrivedi134 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Nov 6, 2023

closing in favor of actions/create-github-app-token#77. The issue is not related to octokit, let's discuss over at the repository of the GitHub Action itself

@gr2m gr2m closed this as completed Nov 6, 2023
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants