Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump Octokit deps to fix Deno compatibility, new endpoints via @octokit/plugin-rest-endpoint-methods #2788

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

wolfy1339
Copy link
Member

See #2762 (comment)

Resolves #ISSUE_NUMBER


Before the change?

  • Types would include a reference to @types/node even though there is nothing using Node specific APIs in the types

After the change?

  • Update @octokit/types to make sure types are platform agnostic
  • Update all Octokit dependencies to their latest version to ensure we pull in the latest version of @octokit/types

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented deno labels Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 marked this pull request as ready for review January 8, 2025 18:39
@wolfy1339 wolfy1339 changed the title fix(deps): bump Octokit deps to fix Deno compatibility fix(deps): bump Octokit deps to fix Deno compatibility, new endpoints via @octokit/plugin-rest-endpoint-methods Jan 8, 2025
@wolfy1339 wolfy1339 requested a review from oscard0m January 8, 2025 18:40
@wolfy1339 wolfy1339 changed the title fix(deps): bump Octokit deps to fix Deno compatibility, new endpoints via @octokit/plugin-rest-endpoint-methods feat(deps): bump Octokit deps to fix Deno compatibility, new endpoints via @octokit/plugin-rest-endpoint-methods Jan 8, 2025
@wolfy1339 wolfy1339 merged commit 2107d79 into main Jan 8, 2025
7 checks passed
@wolfy1339 wolfy1339 deleted the bump-octokit branch January 8, 2025 18:50
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 10, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.0.3 | 4.1.0 |


## [v4.1.0](https://github.com/octokit/octokit.js/releases/tag/v4.1.0)

##### Features

-   **deps:** bump Octokit deps to fix Deno compatibility, new endpoints via `@octokit/plugin-rest-endpoint-methods` ([#2788](octokit/octokit.js#2788)) ([2107d79](octokit/octokit.js@2107d79))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 10, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.0.3 | 4.1.0 |


## [v4.1.0](https://github.com/octokit/octokit.js/releases/tag/v4.1.0)

##### Features

-   **deps:** bump Octokit deps to fix Deno compatibility, new endpoints via `@octokit/plugin-rest-endpoint-methods` ([#2788](octokit/octokit.js#2788)) ([2107d79](octokit/octokit.js@2107d79))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno released Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants