You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that this was giving me 404 errors when trying to use this method with an org ID against a GHES server:
[6] pry(main)> c.update_org_membership(12, user: 'some-user')
Octokit::NotFound: PUT https://[MY-GHES-SERVER]/api/v3/orgs/12/memberships/some-user: 404 - Not Found // See: https://developer.github.com/enterprise/2.20/v3/orgs/members/#add-or-update-organization-membership
from /Users/tim/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/octokit-4.8.0/lib/octokit/response/raise_error.rb:16:in `on_complete'
I've worked around this by ensuring I use the org's name when I use the method instead of the ID, but I believe the method should be rewritten as follows, so that it can accept both (as it is in organization_membership, for example):
It looks like the path being used in line 704 of the
update_organization_membership
method is hardcoded, instead of usingOrganization.path
:octokit.rb/lib/octokit/client/organizations.rb
Lines 700 to 709 in 9560329
I found that this was giving me 404 errors when trying to use this method with an org ID against a GHES server:
I've worked around this by ensuring I use the org's name when I use the method instead of the ID, but I believe the method should be rewritten as follows, so that it can accept both (as it is in
organization_membership
, for example):The text was updated successfully, but these errors were encountered: