Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Missing endpoints for management of runner groups on the Repo and Org level #618

Open
1 task done
Eddman opened this issue Nov 1, 2023 · 3 comments
Open
1 task done
Labels
Type: Bug Something isn't working as documented

Comments

@Eddman
Copy link
Contributor

Eddman commented Nov 1, 2023

What happened?

I'm upgrading to newer plugin-enterprise-server.js (from 10.6.4 to 15.1.3) and realized that endpoints that I used and are still part of GitHub ES 3.9 are missing:

Before that I used these without issues.

Versions

"@octokit/plugin-enterprise-server": "^15.1.3",
"probot": "^13.0.0-beta.2",

NodeJS 20.9.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Eddman Eddman added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Nov 1, 2023
@wolfy1339
Copy link
Member

Thanks for taking the time for testing out Probot v13, and reporting this issue.

The routes are auto generated from GitHub's OpenAPI spec, we don't manually add them.
However the GitHub docs for the REST API are also generated from the OpenAPI spec.

We don't take in account the API versioning in Octokit anywhere, yet.

It's possible that it is still present in 2022-11-28 but not in the unversioned spec

@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Nov 1, 2023
@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label Nov 1, 2023
@Eddman
Copy link
Contributor Author

Eddman commented Nov 2, 2023

Hard to say, I checked specs for Server 3.9 and 3.10 and the API is there. I can't unselect the API version and even if I try to remove it from URL it is auto-added by GH web...

Looking at the plugin-enterprise-cloud.js it has these endpoints there. And both EC and ES use the same spec.

So to me it looks like these are filtered out somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants