Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually output only ESM #178

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: actually output only ESM #178

merged 2 commits into from
Mar 8, 2024

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Mar 8, 2024

Resolves #177


Before the change?

  • Outputted CJS even though the package is marked as being ESM

After the change?

  • Output a single ES2022 ESM bundle

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Provide a single ES2022 bundle for all platforms
Fixes #177
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

I feel like we should have some smoke tests that import the build output and would detect this

@gr2m
Copy link
Contributor

gr2m commented Mar 8, 2024

I feel like we should have some smoke tests that import the build output and would detect this

yes, always, we should. Thank you for adding it

Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: '@octokit/plugin-paginate-graphql' does not provide an export named 'paginateGraphQL'
2 participants