-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): switch to esbuild #82
Conversation
I can reproduce these build errors...I'm not sure what's going wrong in the build process yet. |
Is it a type that's imported? That would probably be the best guess |
Interestingly, the type is exported correctly from the .ts file as far as I can tell, but upon build, those types aren't present in the corresponding .js file. There may be an issue with the build process that's preventing the proper artifacts from being emitted. |
You need to explicitly mark the import for types. Like so: import type { Foo } from "bar"; |
That should be marked explicitly for type exports, the same way as for imports as listed above |
🤦 🤦 🤦 Thank you so much! I had clearly missed that. |
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replicating octokit/request.js#584 to another repo.
Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.
Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle
Uses the TypeScript compiler to generate the types.
Behavior
Before the change?
dist-node
,dist-types
,dist-web
... even though they are generated correctly.After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Maintenance