Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove NodeJS/Browser specific builds #404

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Feb 23, 2024

Resolves #ISSUE_NUMBER


Before the change?

  • Published a NodeJS build, a Browser build and a neutral source transpilation
  • Users who have the moduleResolution option in their tsconfig.json set to bundler couldn't consume the package

After the change?

  • Only publishes the neutral source transpilation, as in this case all the builds were the same
  • Reduces size of the NPM package
  • Users who have the moduleResolution option in their tsconfig.json set to bundler can consume the package

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The 2 builds are the same in this case. It fixes usage with the `moduleResolution` option set to `bundler`
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 23, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit 479d0b4 into main Feb 23, 2024
6 checks passed
@wolfy1339 wolfy1339 deleted the fix-build branch February 23, 2024 20:11
Copy link

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benjamin-guibert
Copy link

@wolfy1339 It likely seems to have solved my "module not found" issue. Thank you for your work! 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants