fix: implement some performance improvements (#667)

* Pre-compute the keys of the `Endpoint` type in order to not have to compute them multiple times
* Use interface extends instead of intersections

See https://github.com/microsoft/TypeScript/wiki/Performance
Part of #666

Author: wolfy1339

scripts/update-endpoints/templates/endpoints.ts.template

@@ -116,4 +116,6 @@ export interface Endpoints {
     "{{method}}"
   >,
   {{/each}}
-}
+}
+
+export type EndpointKeys = keyof Endpoints;

src/EndpointDefaults.ts

@@ -7,7 +7,7 @@ import type { Url } from "./Url.js";
  * The `.endpoint()` method is guaranteed to set all keys defined by RequestParameters
  * as well as the method property.
  */
-export type EndpointDefaults = RequestParameters & {
+export interface EndpointDefaults extends RequestParameters {
   baseUrl: Url;
   method: RequestMethod;
   url?: Url;
@@ -19,4 +19,4 @@ export type EndpointDefaults = RequestParameters & {
     format: string;
     previews?: string[];
   };
-};
+}

src/EndpointInterface.ts

@@ -3,7 +3,7 @@ import type { RequestOptions } from "./RequestOptions.js";
 import type { RequestParameters } from "./RequestParameters.js";
 import type { Route } from "./Route.js";
 
-import type { Endpoints } from "./generated/Endpoints.js";
+import type { EndpointKeys, Endpoints } from "./generated/Endpoints.js";
 
 export interface EndpointInterface<D extends object = object> {
   /**
@@ -25,13 +25,13 @@ export interface EndpointInterface<D extends object = object> {
    */
   <
     R extends Route,
-    P extends RequestParameters = R extends keyof Endpoints
+    P extends RequestParameters = R extends EndpointKeys
       ? Endpoints[R]["parameters"] & RequestParameters
       : RequestParameters,
   >(
-    route: keyof Endpoints | R,
+    route: EndpointKeys | R,
     parameters?: P,
-  ): (R extends keyof Endpoints ? Endpoints[R]["request"] : RequestOptions) &
+  ): (R extends EndpointKeys ? Endpoints[R]["request"] : RequestOptions) &
     Pick<P, keyof RequestOptions>;
 
   /**
@@ -57,14 +57,14 @@ export interface EndpointInterface<D extends object = object> {
      */
     <
       R extends Route,
-      P extends RequestParameters = R extends keyof Endpoints
+      P extends RequestParameters = R extends EndpointKeys
         ? Endpoints[R]["parameters"] & RequestParameters
         : RequestParameters,
     >(
-      route: keyof Endpoints | R,
+      route: EndpointKeys | R,
       parameters?: P,
     ): D &
-      (R extends keyof Endpoints
+      (R extends EndpointKeys
         ? Endpoints[R]["request"] & Endpoints[R]["parameters"]
         : EndpointDefaults) &
       P;

src/EndpointOptions.ts

@@ -2,7 +2,7 @@ import type { RequestMethod } from "./RequestMethod.js";
 import type { Url } from "./Url.js";
 import type { RequestParameters } from "./RequestParameters.js";
 
-export type EndpointOptions = RequestParameters & {
+export interface EndpointOptions extends RequestParameters {
   method: RequestMethod;
   url: Url;
-};
+}

src/RequestInterface.ts

@@ -3,7 +3,7 @@ import type { OctokitResponse } from "./OctokitResponse.js";
 import type { RequestParameters } from "./RequestParameters.js";
 import type { Route } from "./Route.js";
 
-import type { Endpoints } from "./generated/Endpoints.js";
+import type { EndpointKeys, Endpoints } from "./generated/Endpoints.js";
 
 export interface RequestInterface<D extends object = object> {
   /**
@@ -24,11 +24,11 @@ export interface RequestInterface<D extends object = object> {
    * @param {object} [parameters] URL, query or body parameters, as well as `headers`, `mediaType.{format|previews}`, `request`, or `baseUrl`.
    */
   <R extends Route>(
-    route: keyof Endpoints | R,
-    options?: R extends keyof Endpoints
+    route: EndpointKeys | R,
+    options?: R extends EndpointKeys
       ? Endpoints[R]["parameters"] & RequestParameters
       : RequestParameters,
-  ): R extends keyof Endpoints
+  ): R extends EndpointKeys
     ? Promise<Endpoints[R]["response"]>
     : Promise<OctokitResponse<any>>;
 

src/generated/Endpoints.ts

@@ -6903,3 +6903,5 @@ export interface Endpoints {
     "put"
   >;
 }
+
+export type EndpointKeys = keyof Endpoints;