Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: WebStandard Middleware #1063

Open
1 task done
akku1139 opened this issue Sep 30, 2024 · 3 comments · May be fixed by #1078
Open
1 task done

[FEAT]: WebStandard Middleware #1063

akku1139 opened this issue Sep 30, 2024 · 3 comments · May be fixed by #1078
Labels
Type: Feature New feature or request

Comments

@akku1139
Copy link

Describe the need

Currently, octokit only supports creating middleware for Node.js ,
but there are times when I want to use octokit in an environment other than Node.js .
This is not a big problem with runtimes that are compatible with Node.js, such as Deno and Bun,
Edge runtimes such as Cloudflare Workers may not offer Node.js compatibility.
Therefore, it is necessary to provide Middleware that uses WebStandard API (Request/Response).

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@akku1139 akku1139 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Sep 30, 2024
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

I created this middleware, https://github.com/octokit/webhooks.js/compare/web-middleware

@akku1139
Copy link
Author

akku1139 commented Oct 2, 2024

app.js and oauth-app.js also need to be supported in the same way.


It was already supported in oauth-app.js

https://github.com/octokit/oauth-app.js/blob/main/src/middleware/web-worker/index.ts

@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Oct 7, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Oct 7, 2024
@wolfy1339 wolfy1339 linked a pull request Nov 26, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Status: 🔥 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants