Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery mixin doesn't respect gutter override #404

Open
jtwalters opened this issue Nov 12, 2014 · 3 comments
Open

Gallery mixin doesn't respect gutter override #404

jtwalters opened this issue Nov 12, 2014 · 3 comments

Comments

@jtwalters
Copy link

e.g. "no-gutters" override is not respected in the gallery mixin. It uses the default gutter value.

See my reduced test case at http://sassmeister.com/gist/81552e16e6ba43b3c240

@mirisuzanne
Copy link
Member

Interesting. I see how that's confusing, but it's because of an important difference between no-gutters and gutters: 0. Setting gutters to 0 actually changes your grid to work without gutters. no-gutters is a keyword that is used to not apply gutters in one specific location, without changing how the grid math is calculated.

Removing gutters from a gallery would require a change in the overall math. It's not just a matter of removing gutter output, you have to fill that space by making columns wider. For that, you need gutters: 0.

I'll keep this open as a bit of confusion to address next time we're making changes to syntax, but I'm not sure the solution is obvious.

@TylikStec
Copy link

what about changing @include gallery(2 of 12) to @include gallery(4 of 24)? It'll make "gutter" twice smaller. You can doing this further e.g. @include gallery(10 of 60)

@mirisuzanne
Copy link
Member

mirisuzanne commented Nov 22, 2016

If you want to remove the gutters entirely, the more robust technical solution is

@include gallery(2 of 12 (gutters: 0))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants