Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-true compatibility #176

Closed
hochan222 opened this issue Sep 25, 2020 · 1 comment · Fixed by #178
Closed

sass-true compatibility #176

hochan222 opened this issue Sep 25, 2020 · 1 comment · Fixed by #178
Labels
dependencies Pull requests that update a dependency file documentation PR required

Comments

@hochan222
Copy link

First of all, thank you for creating a library so that I can conveniently unit test with sass.

It was installed according to the following dependencies, and it was successful.

  "dependencies": {
    "glob": "^7.1.6",
    "jest": "^25.1.0",
    "node-sass": "^4.13.1",
    "sass-true": "^5.0.0"
  }

However, if you install the latest version for each module, it looks like the following.
The following version compatibility issues occur.

  "dependencies": {
    "glob": "^7.1.6",
    "jest": "^26.4.2",
    "sass-true": "^6.0.0",
    "node-sass": "^4.14.1"
  }

image

Although the version problem between node-sass and node was correct, it seems that it is a sass-true compatibility problem.

Even if I refer to the sass-true document, there is no information on compatibility, so can you give me a link or add it to the main README.md?

@mirisuzanne
Copy link
Member

The latest upgrade does require Sass Modules, currently only in Dart Sass.

Node Sass is likely to deprecate soon as an official Sass implementation, since the project has fallen several years behind the Sass specification. It's highly recommended that you move to Dart Sass, which is the reference implementation, and always has the latest feature support.

That's mentioned at various places in the Readme & Changelog, but you're right that we should probably make it more prominent. Happy to accept a PR, or I'll try and get to it soon.

Thanks!

@mirisuzanne mirisuzanne added PR required dependencies Pull requests that update a dependency file documentation labels Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation PR required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants