Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not right arc for absolute middle horizontal and vertical #2

Open
AndreaBarghigiani opened this issue Jun 21, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@AndreaBarghigiani
Copy link
Contributor

With a path defined as follows, we get the wrong values drawing the arcs.

const notPlayWellMiddleHorizontal = [
  ["h", 30],
  ["v", 10],
  ["H", 150],
  ["v", 5],
  ["H", 75],
  ["v", 15],
  ["H", "close"],
  ["v", 70],
  ["H", 250],
  ["v", -5],
  ["H", 375],
  ["v", 5],
  ["H", "start"],
  ["v", -30],
  ["H", -60],
  ["v", -35],
  ["H", "start"],
  ["v", -35],
];

As you can see from the image below the issue is present for the shape at the bottom and for the first two arcs that get's created while closing the shape.
wrong-horizontal-arc

TODO:
Improve checks for the createArc() function.

@AndreaBarghigiani AndreaBarghigiani added the bug Something isn't working label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant