Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite durability issues with old scrolls from before the 1.21 update. #276

Closed
FaultyFunctions opened this issue Nov 9, 2024 · 2 comments

Comments

@FaultyFunctions
Copy link

Old scrolls before the update are experiencing issues where the durability will only go down by 1, but they will stay at that level forever. They won't break and when the user logs out and back in, the durability is being set back to maximum. The console is showing [vane-core] Updated item durability vane_trifles:home_scroll when this happens. Any ideas what's going on?

@FaultyFunctions
Copy link
Author

Also happens on opening scrolls in an enderchest. Something is failing in the vane/vane-core/src/main/java/org/oddlama/vane/core/item/ExistingItemConverter.java script in the process_inventory function.

@oddlama
Copy link
Owner

oddlama commented Nov 14, 2024

Yes you are right, the old values seem to be persisted after converting to the new vanilla durability system. And then they are converted each time which resets the durability to the old value.

Thanks for noticing, will be fixed in the next release (when PaperMC releases a stable 1.21.3 in the coming days) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants