-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Wrapper Feature Flag #218
base: main
Are you sure you want to change the base?
Conversation
Let me know if this is similar to your idea. Best example is |
Could the following work? Move these enumeration types into a
also add all implementations on above types, such as: From<&Message> for CacheEvents and (should we have it): From<Event> for DocumentEvents even our big: From<&Message> for Event But, for instance not: From<CacheEvents> for CacheAddEvent People could want to opt out of // pseudo rust
while Some(Ok(msg)) = stream.next()? {
select! {
CacheAddEvent::try_from(msg)? => got_cache_add(add);
CaretMovedEvent::try_from(msg)? => caret_moved(moved);
}
} There is likely a thousand things wrong with above, but the gist is one could write this and not have |
Consider it done. Working on it now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 83.87% 85.85% +1.98%
==========================================
Files 43 42 -1
Lines 3231 3154 -77
==========================================
- Hits 2710 2708 -2
+ Misses 521 446 -75 ☔ View full report in Codecov by Sentry. |
…ype` Macro `impl_try_from_event_for_user_facing_event_type` does not implement trait for user facing type at all. Now named: `impl_try_from_event_for_interface_enum`
4abb224
to
e61efd6
Compare
atspi-common/src/events/*
intoatspi-common/src/events/wrapper/*