Completely Refactoer #120
Closed
Completely Refactoer #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
===========================================
+ Coverage 14.15% 42.36% +28.20%
===========================================
Files 16 22 +6
Lines 1533 1100 -433
===========================================
+ Hits 217 466 +249
+ Misses 1316 634 -682 ☔ View full report in Codecov by Sentry. |
1. Use type aliases to define state field types (for use outside the state module). 2. std::sync::Mutex -> parking_lot::RwLock (parking lot and rw lock are more efficient)
…interact with eachother.
…turns a cache reference
…can not be poisoned; impl Debug on the Operation type
These are conceptually separated by being direct *internal* events that modify Odilia's state. As opposed to events, which are generally recieved from the outside. Also adds a few more Defualt implementations.
|
Hello, Currently I've started to work on the project. What kind of refactors you are doing at this time? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odilia-commoncomparable on any architecture withstd.wasm32-wasiandwasm32-unknown-unknowncompilation ofodilia-common.atspi-clientlogic back into Odilia via more internal cache traits. This can be re-exported later, but the wholeAccessibleExtsystem has to go, it doesn't work with this new architecture very well.odilia/src/events/*functions to(Try)From<$atspi_event> for Vec<OdiliaEvent>.${event}FunctionParamsstructure to be created from($event, &state).(Try)From<${event}FunctionParams for Vec<OdiliaEvent>.OdiliaEvent. The resulting code should look similar to:<$odilia_evnet>::get_state_pieces(&State) -> ${odilia_event}States;then$[odilia_event}State.apply_changes(). Only withinapply_changesshould there by mutable access to any part of the state. Before this, you may useArc<T>,RwLock<T>, orTif it is thread-safe.Vec<OdiliaEvent>. Test for all major events. No need for 100%.This basically sets the stage for the plugin system.
Now, state is stored entirely separate to the types, and can be queried through provided functions like
query_parent(Accessible) -> Accessiblewhich will be implemented as guest-available functions once the plugin system is ready.Note: this PR DOES NOT implement any kind of plugin system, it merely sets everything up to be easy to test the core, and easy to integrate
pre-*andpost-*hooks on each major category of event.Although I'll be taking suggestions, I will not be doing a formal code review because there simply are not the available man hours for that. The new testing should suffice as proof of sound reasoning.