Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deformation operators #464

Closed
1 of 2 tasks
kohr-h opened this issue Jun 22, 2016 · 7 comments
Closed
1 of 2 tasks

Deformation operators #464

kohr-h opened this issue Jun 22, 2016 · 7 comments
Assignees

Comments

@kohr-h
Copy link
Member

kohr-h commented Jun 22, 2016

We need a framework for handling deformations defined by certain actions of deformation groups.

  • PR 488 Currently, we have the "standard" group action defined by right composition
phi.f = f o phi = ( x --> f(phi(x)) )
  • Issue 505 and the mass-preserving group action using
phi.f = |det(Dphi)| f o phi = ( x --> |det(Dphi(x))| f(phi(x)) )

where Dphi(x) is the Jacobian matrix of phi in x.

@adler-j
Copy link
Member

adler-j commented Aug 18, 2016

edited the issue to add checklist, checked of non mass preserving and added link to the mass preserving case.

@chongchenmath
Copy link
Member

For the mass-preserving or standard deformation operator, the case is a little bit complicated with regard to the derivative and its adjoint. Sometimes we need to compute the Eulerian derivative rather than the standard derivative. So we can first just implement the deformation operator itself.

@kohr-h
Copy link
Member Author

kohr-h commented Aug 19, 2016

For us, operator.derivative is always the standard derivative. If the Eulerian derivative is required somewhere, it needs to be a separate operator.

@chongchenmath
Copy link
Member

Yes. But the operator.derivative might be useless. The another problem is the group actions like: phi.f = f o phi^{-1} or phi.f = |det(Dphi^{-1})| f o phi^{-1} where the phi^{-1} and |det(Dphi^{-1})| are given as arguments directly, rather computed from phi.

@kohr-h
Copy link
Member Author

kohr-h commented Aug 19, 2016

Yes. But the operator.derivative might be useless.

If it's useless, we don't implement it.

The another problem is the group actions like: phi.f = f o phi^{-1} or phi.f = |det(Dphi^{-1})| f o phi^{-1} where the phi^{-1} and |det(Dphi^{-1})| are given as arguments directly, rather computed from phi.

Makes sense, I don't see a problem as long as we don't need phi as well.

@chongchenmath
Copy link
Member

Agree. The phi^{-1} can be seen as a general deformation, and the f o deformation and |det(D deformation)| f o deformation is always useful.

@adler-j
Copy link
Member

adler-j commented Jun 29, 2017

Closing this in favor of #505 which covers whats left.

@adler-j adler-j closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants