[FIX] range: invalid sheet name with special character

If we have a range with an invalid sheet name, the sheet name is not
escaped with quotes when it contains special characters when converting
the range back to a string.

closes #7416

Task: 5125762
X-original-commit: d9d0f31
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/plugins/core/range.ts

@@ -401,7 +401,7 @@ export class RangeAdapter implements CommandHandler<CoreCommand> {
     let sheetName: string = "";
     if (prefixSheet) {
       if (rangeImpl.invalidSheetName) {
-        sheetName = rangeImpl.invalidSheetName;
+        sheetName = getCanonicalSymbolName(rangeImpl.invalidSheetName);
       } else {
         sheetName = getCanonicalSymbolName(this.getters.getSheetName(rangeImpl.sheetId));
       }

tests/model/model_import_export.test.ts

@@ -293,7 +293,7 @@ describe("Migrations", () => {
 
     const cfs = data.sheets[1].conditionalFormats;
     const rule1 = cfs[0].rule as ColorScaleRule;
-    expect(cfs[0].ranges).toEqual(["=sheetName_!A1:A2"]);
+    expect(cfs[0].ranges).toEqual(["'=sheetName_'!A1:A2"]);
     expect(rule1.minimum.value).toEqual("=sheetName_!B1");
     expect(rule1.midpoint?.value).toEqual("=sheetName_!B1");
     expect(rule1.maximum.value).toEqual("=sheetName_!B1");
@@ -304,7 +304,7 @@ describe("Migrations", () => {
     expect(rule2.upperInflectionPoint.value).toEqual("=sheetName_!B1");
 
     const rule3 = cfs[2].rule as ColorScaleRule;
-    expect(cfs[2].ranges).toEqual(["=sheetName_!A1:A2"]);
+    expect(cfs[2].ranges).toEqual(["'=sheetName_'!A1:A2"]);
     expect(rule3.minimum.value).toEqual("33");
     expect(rule3.midpoint?.value).toEqual("13");
     expect(rule3.maximum.value).toBeUndefined();

tests/range_plugin.test.ts

@@ -551,11 +551,16 @@ describe("range plugin", () => {
       }
     );
 
+    test("invalid sheet name with special character", () => {
+      const range = m.getters.getRangeFromSheetXC("s1", "'Invalid Sheet Name'!A1");
+      expect(m.getters.getRangeString(range, "s1")).toBe("'Invalid Sheet Name'!A1");
+    });
+
     test.each([
       ["s1!!!A1:A9", "'s1!!'!A1:A9"],
       ["'s1!!'!A1:A9", "'s1!!'!A1:A9"],
-      ["s1!!!A1:s1!!!A9", "s1!!!A1:s1!!!A9"],
-      ["s1!!!A1:s1!!!A9", "s1!!!A1:s1!!!A9"],
+      ["s1!!!A1:s1!!!A9", "'s1!!!A1:s1!!'!A9"],
+      ["s1!!!A1:s1!!!A9", "'s1!!!A1:s1!!'!A9"],
     ])(
       "xc with more than one exclamation mark does not throw error",
       (rangeString, expectedString) => {