[FIX] composer: change mode to editing when composer cursor selection changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

closes #7483

Task: 5226615
X-original-commit: e3c5dea
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>

Author: rmbh-odoo

src/components/composer/composer/abstract_composer_store.ts

@@ -131,6 +131,7 @@ export abstract class AbstractComposerStore extends SpreadsheetStore {
     }
     this.selectionStart = start;
     this.selectionEnd = end;
+    this.editionMode = "editing";
     this.computeFormulaCursorContext();
     this.computeParenthesisRelatedToCursor();
   }

src/components/composer/composer/composer.ts

@@ -561,9 +561,7 @@ export class Composer extends Component<CellComposerProps, SpreadsheetChildEnv>
     }
     const newSelection = this.contentHelper.getCurrentSelection();
 
-    this.props.composerStore.stopComposerRangeSelection();
     this.props.onComposerContentFocused();
-
     this.props.composerStore.changeComposerCursorSelection(newSelection.start, newSelection.end);
     this.processTokenAtCursor();
   }

src/helpers/pivot/pivot_composer_helpers.ts

@@ -52,7 +52,6 @@ export function insertTokenAfterArgSeparator(
     // replace the whole token
     start = tokenAtCursor.start;
   }
-  this.composer.stopComposerRangeSelection();
   this.composer.changeComposerCursorSelection(start, end);
   this.composer.replaceComposerCursorSelection(value);
 }
@@ -75,7 +74,6 @@ export function insertTokenAfterLeftParenthesis(
     // replace the whole token
     start = tokenAtCursor.start;
   }
-  this.composer.stopComposerRangeSelection();
   this.composer.changeComposerCursorSelection(start, end);
   this.composer.replaceComposerCursorSelection(value);
 }

tests/composer/autocomplete_dropdown_component.test.ts

@@ -495,7 +495,6 @@ describe("Autocomplete parenthesis", () => {
   test("=S( + edit S with autocomplete does not add left parenthesis", async () => {
     composerEl = await typeInComposer("=S(");
     // go behind the letter "S"
-    composerStore.stopComposerRangeSelection();
     composerStore.changeComposerCursorSelection(2, 2);
     await nextTick();
     // show autocomplete

tests/composer/composer_store.test.ts

@@ -124,6 +124,13 @@ describe("edition", () => {
     expect(composerStore.editionMode).toBe("inactive");
   });
 
+  test("should switch to editing mode when composer cursor selection changes", () => {
+    composerStore.startEdition("=sum(");
+    expect(composerStore.editionMode).toBe("selecting");
+    composerStore.changeComposerCursorSelection(0, 5);
+    expect(composerStore.editionMode).toBe("editing");
+  });
+
   test("Stopping the edition should complete the missing parenthesis of a formula", async () => {
     composerStore.startEdition("=sum(sum(1,2");
     composerStore.stopEdition();
@@ -344,7 +351,6 @@ describe("edition", () => {
   test("selecting insert range in selecting mode", () => {
     composerStore.startEdition();
     composerStore.setCurrentContent("=");
-    composerStore.changeComposerCursorSelection(1, 1);
 
     setSelection(model, ["A1:A3"]);
     expect(composerStore.currentContent).toBe("=A1:A3");