[IMP] estate: correct according pep8

Author: matho-odoo

estate/models/estate_property.py

@@ -31,21 +31,21 @@ class EstateProperty(models.Model):
         default='New'
     )
     active = fields.Boolean(default=True)
-    salesman = fields.Many2one("res.users")
-    buyer = fields.Many2one("res.partner", copy=False)
+    salesman_id = fields.Many2one("res.users")
+    buyer_id = fields.Many2one("res.partner", copy=False)
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     property_type_id = fields.Many2one("estate.property.type")
     offer_ids = fields.One2many("estate.property.offer", "property_id")
-    total_area = fields.Float(compute="_compute_total")
-    best_price = fields.Float(compute="_compute_highest_price")
+    total_area = fields.Float(compute="_compute_total_area")
+    best_price = fields.Float(compute="_compute_best_price")
 
     @api.depends("living_area", "garden_area")
-    def _compute_total(self):
+    def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
     @api.depends("offer_ids")
-    def _compute_highest_price(self):
+    def _compute_best_price(self):
         for record in self:
             record.best_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0
 
@@ -62,18 +62,18 @@ def _unlink_if_new_or_cancelled(self):
                 raise UserError(_("Seules les propriétés 'New' ou 'Cancelled' peuvent être supprimées."))
 
     def action_mark_as_sold(self):
-        for record in self:
-            if record.state == "Cancelled":
-                raise UserError(_("Cette vente a été annulée"))
-            record.state = "Sold"
-            return True
+        self.ensure_one()
+        if self.state == "Cancelled":
+            raise UserError(_("Cette vente a été annulée"))
+        self.state = "Sold"
+        return True
 
     def action_mark_as_cancelled(self):
-        for record in self:
-            if record.state == "Sold":
-                raise UserError(_("Cette maison a déjà été vendue"))
-            record.state = "Cancelled"
-            return True
+        self.ensure_one()
+        if self.state == "Sold":
+            raise UserError(_("Cette maison a déjà été vendue"))
+        self.state = "Cancelled"
+        return True
 
     @api.constrains("selling_price", "expected_price")
     def _check_selling_price_is_ok(self):

estate/models/estate_property_offer.py

@@ -15,25 +15,29 @@ class EstatePropertyOffer(models.Model):
     property_id = fields.Many2one("estate.property", required=True)
     property_type_id = fields.Many2one(related="property_id.property_type_id", store=True)
     validity = fields.Integer(default=7)
-    date_deadline = fields.Date(compute="_compute_deadline", inverse="_inverse_deadline")
+    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
 
     @api.depends("validity")
-    def _compute_deadline(self):
+    def _compute_date_deadline(self):
         for record in self:
             record.date_deadline = fields.Date.add(record.create_date or fields.Date.today(), days=record.validity)
 
-    def _inverse_deadline(self):
+    def _inverse_date_deadline(self):
         for record in self:
             record.validity = (record.date_deadline - fields.Date.to_date(record.create_date)).days
 
     def action_accept(self):
+        self.ensure_one()
+        if float_compare(self.price, self.property_id.best_price, 2) == -1:
+            raise ValidationError(_("Cette offre ne peut pas être acceptée car son montant est inférieur à %d", self.property_id.best_price))
         self.status = "Accepted"
         self.property_id.state = "Offer Accepted"
-        self.property_id.buyer = self.partner_id
+        self.property_id.buyer_id = self.partner_id
         self.property_id.selling_price = self.price
         return True
 
     def action_refuse(self):
+        self.ensure_one()
         self.status = "Refused"
         return True
 
@@ -45,6 +49,11 @@ def _check_offer_price_is_ok(self):
 
     @api.model_create_multi
     def create(self, vals_list):
+        property_ids =[offer['property_id'] for offer in vals_list]
+        properties = self.env["estate.property"].browse(property_ids)
+        for property in properties:
+            if property.state in ['Offer Accepted', 'Sold', 'Cancelled']:
+                raise ValidationError(_("Aucune n'offre ne peut être réalisée sur cette propriété actuellement."))
         offers = super().create(vals_list)
         offers.property_id.state = 'Offer Received'
         return offers

estate/models/res_users.py

@@ -4,4 +4,4 @@
 class ResUsers(models.Model):
     _inherit = "res.users"
 
-    property_ids = fields.One2many("estate.property", "salesman", domain=[('state', 'in', ['New', 'Offer Received'])])
+    property_ids = fields.One2many("estate.property", "salesman_id", domain=[('state', 'in', ['New', 'Offer Received'])])

estate/views/estate_property_views.xml

@@ -51,7 +51,7 @@
             <header>
                 <button name="action_mark_as_sold" type="object" string="Sold" invisible="state in ['Offer Accepted', 'Sold', 'Cancelled']"/>
                 <button name="action_mark_as_sold" type="object" string="Sold" class="btn-primary" invisible="state != 'Offer Accepted'"/>
-                <button name="action_mark_as_cancelled" type="object" string="Cancelled" invisible="state == 'Sold' or state == 'Cancelled'"/>
+                <button name="action_mark_as_cancelled" type="object" string="Cancelled" invisible="state in ['Sold', 'Cancelled']"/>
                 <field name="state" widget="statusbar" statusbar_visible="New,Offer Received,Offer Accepted,Sold"/>
             </header>
             <sheet>
@@ -86,7 +86,8 @@
                         </group>
                     </page>
                     <page string="Offers">
-                        <field name="offer_ids" readonly="state in ['Offer Accepted', 'Sold', 'Cancelled']">
+                        <!--<field name="offer_ids" readonly="state in ['Offer Accepted', 'Sold', 'Cancelled']">-->
+                        <field name="offer_ids">
                             <list editable="bottom" decoration-success="status == 'Accepted'" decoration-danger="status == 'Refused'">
                                 <field name="price"/>
                                 <field name="partner_id"/>
@@ -98,8 +99,8 @@
                     </page>
                     <page string="Other Info">
                         <group>
-                            <field name="salesman"/>
-                            <field name="buyer"/>
+                            <field name="salesman_id"/>
+                            <field name="buyer_id"/>
                         </group>
                     </page>
 
@@ -118,7 +119,7 @@
                 <field name="postcode"/>
                 <field name="expected_price"/>
                 <field name="bedrooms"/>
-                <field name="living_area" filter_domain="[('living_area', '>=', self)]"/>
+                <field name="living_area" filter_domain="[('living_area', '&gt;=', self)]"/>
                 <field name="facades"/>
                 <filter name="group_by_postcode" context="{'group_by': 'postcode'}"/>
                 <filter name="availibility" string="Available" domain="['|', ('state', '=', 'New'),('state', '=', 'Offer Received')]"/>

estate_account/models/estate_property.py

@@ -6,6 +6,7 @@ class EstateProperty (models.Model):
     _inherit = ["estate.property"]
 
     def action_mark_as_sold(self):
+        self.ensure_one()
         res = super().action_mark_as_sold()
         self.env["account.move"].create({
             "line_ids": [