[FIX] util/orm.py: fix custom_module_field_as_manual transient access

From Odoo version 14.0 transient models require access rights (see
related odoo/odoo#43306) instead of implicit access. This can lead to
access errors in `custom_module_field_as_manual`, particularly in the
test crawler, leading to blocked upgrades.

To reproduce:
- have a v13 db with a custom menu which opens a custom model's view,
having a relational field (e.g. one2many) to a custom transient model,
and have existing records
- run the upgrade test prepare
- upgrade to v14
- run the upgrade test check, the TestCrawler will fail with an
AccessError

To fix that, create temporary access rights for custom transient models
while using the context manager.

upg-1157201

Author: erl-odoo

src/util/orm.py

@@ -7,6 +7,8 @@
 from operator import itemgetter
 from textwrap import dedent
 
+from psycopg2.extras import execute_values
+
 try:
     from unittest.mock import patch
 except ImportError:
@@ -424,6 +426,37 @@ def custom_module_field_as_manual(env, rollback=True, do_flush=False):
         )
         mock_x_email_fields = [r[0] for r in env.cr.fetchall()]
 
+    temp_ir_model_access_ids = []
+    if version_gte("14.0") and custom_models:
+        # 1.2 Version 14.0 and above requires new access rights for transient models,
+        # and the rights are yet to be added post standard upgrade for custom modules.
+        # To avoid access errors, create some temporary access rights for these models.
+        env.cr.execute(
+            """
+                SELECT id
+                  FROM ir_model
+                 WHERE model IN %s
+                   AND transient
+                   AND id NOT IN (
+                           SELECT DISTINCT model_id
+                             FROM ir_model_access
+                            WHERE active
+                       )
+            """,
+            [custom_models],
+        )
+
+        no_access_custom_transient_ids = env.cr.fetchall()
+
+        if no_access_custom_transient_ids:
+            insert_query = """
+                INSERT INTO ir_model_access (name, active, model_id, perm_read, perm_write, perm_create, perm_unlink)
+                     VALUES ('tmp_access', true, %s, true, true, true, true)
+                  RETURNING id
+            """
+            execute_values(env.cr._obj, insert_query, no_access_custom_transient_ids)
+            temp_ir_model_access_ids = [r[0] for r in env.cr.fetchall()]
+
     # 2. Convert fields which are not in the registry to `manual` fields
     # and list the fields that were converted, to restore them back afterwards.
     # Also temporarily disable rules (ir.rule) that come from custom modules.
@@ -596,6 +629,8 @@ def patch_display_name():
             )
         if disabled_ir_rule_ids:
             env.cr.execute("UPDATE ir_rule SET active = 't' WHERE id IN %s", (tuple(disabled_ir_rule_ids),))
+        if temp_ir_model_access_ids:
+            env.cr.execute("DELETE FROM ir_model_access WHERE id IN %s", [tuple(temp_ir_model_access_ids)])
         for field_id, selection in updated_selection_fields:
             env.cr.execute("UPDATE ir_model_fields SET selection = %s WHERE id = %s", (selection, field_id))
         for field_id, on_delete in updated_many2one_fields: