Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split config #236

Merged
merged 54 commits into from
Apr 4, 2022
Merged

refactor: split config #236

merged 54 commits into from
Apr 4, 2022

Conversation

deryrahman
Copy link
Member

@deryrahman deryrahman commented Mar 23, 2022 •
edited
Loading

  • implement LoadClientConfig
  • implement LoadServerConfig
  • refactor config load in the corresponding command
  • add config field validation using ozzo-validation
  • refactor config loader in main.go

@deryrahman deryrahman marked this pull request as ready for review March 24, 2022 09:39
@deryrahman deryrahman linked an issue Mar 24, 2022 that may be closed by this pull request
Split the config for server and client #170
Closed
@coveralls
Copy link

coveralls commented Mar 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2088475487

  • 111 of 137 (81.02%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 74.405%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config/telemetry.go 0 1 0.0%
config/loader.go 64 69 92.75%
config/validation.go 40 49 81.63%
config/config_client.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
config/loader.go 1 92.68%
config/config.go 2 0%
Totals Coverage Status
Change from base Build 2088084344: 0.07%
Covered Lines: 5596
Relevant Lines: 7521
💛 - Coveralls

sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
config/config_server.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
config/loader.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
config/loader.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 26, 2022
View reviewed changes
config/validation.go Outdated Show resolved Hide resolved
This was referenced Mar 30, 2022
Merged
Merged
sbchaos
sbchaos reviewed Mar 30, 2022
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 30, 2022
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 30, 2022
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
sbchaos
sbchaos reviewed Mar 30, 2022
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
sravankorumilli
sravankorumilli reviewed Mar 31, 2022
View reviewed changes
cmd/admin.go Show resolved Hide resolved
cmd/backup_create.go Outdated Show resolved Hide resolved
cmd/extension.go Outdated Show resolved Hide resolved
sravankorumilli
sravankorumilli requested changes Mar 31, 2022
View reviewed changes
cmd/job_create.go Show resolved Hide resolved
cmd/resource.go Show resolved Hide resolved
cmd/secret.go Show resolved Hide resolved
cmd/version.go Show resolved Hide resolved
config/config_server.go Outdated Show resolved Hide resolved
config/loader.go Outdated Show resolved Hide resolved
config/validation.go Outdated Show resolved Hide resolved
deryrahman and others added 27 commits April 4, 2022 14:54
@deryrahman
fix: build with BuildVersion
0a75bb1
@deryrahman
refactor: replay struct
a7084c1
@deryrahman
refactor: put comment legacy for the deprecated function
2d125c4
@deryrahman
fix: restore cli request fail
da6bda9
@deryrahman
refactor: pass global repo to relevant commands
9c10de3
@irainia @deryrahman
refactor: extract datastore initialization to a function
45a837f
@irainia @deryrahman
refactor: clean-up variable naming
29e3b98
@deryrahman
fix: use replay struct
940ef44
@deryrahman
fix: accpeting config file path on server command
0e0ce74
@deryrahman
refactor: clean up legacy loader
23b3137
@deryrahman
fix: remove server config load from home dir
380f361
@deryrahman
fix: linter
7c9869c
@deryrahman
add: gitignore for new configs
29a930e
@deryrahman
refactor: move setups in server package
1ef87aa
@deryrahman
refactor: logger & hplugin imported
d1963ef
@deryrahman
fix: type load config server
ae75900
@deryrahman
fix: missing --config flags
aadbf85
@deryrahman
fix: default scheduler in config server
1ed316c
@deryrahman
refactor: passing logger in extension command
46547b0
@deryrahman
fix: initialize pluginRegistry
ef05cec
@deryrahman
refactor: add TODO init paths config
d849fb3
@deryrahman
refactor: add TODO for validation
39b26d2
@deryrahman
fix: executable dir path
545f91f
@deryrahman
refactor: remove global env as a reasons when server is not reachable
e0f4a35
@deryrahman
docs: update config docs
bb6f797
@deryrahman
refactor: initialize dsRepo on backup create command
06df79e
@deryrahman
refactor: remove Validate func
14df505
@deryrahman deryrahman merged commit eb9676a into main Apr 4, 2022
@deryrahman deryrahman deleted the split-config branch April 4, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbchaos sbchaos sbchaos approved these changes

@sravankorumilli sravankorumilli Awaiting requested review from sravankorumilli

@irainia irainia Awaiting requested review from irainia

Assignees

@deryrahman deryrahman

@irainia irainia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the config for server and client
5 participants
@deryrahman @coveralls @sravankorumilli @sbchaos @irainia