Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewGeneratorConnector should be under consuming component #1606

Closed
mandy-chessell opened this issue Sep 20, 2019 · 2 comments
Closed

ViewGeneratorConnector should be under consuming component #1606

mandy-chessell opened this issue Sep 20, 2019 · 2 comments

Comments

@mandy-chessell
Copy link
Contributor

The Interface and base classes for the ViewGeneratorConnector and Provider should be under the consuming component virtualization-services-api. This is so that the virtualizer governance server does not have dependencies on Derby.

For clarity, the DerbyConnector should probably be called the ViewGeneratorDerbyConnector. This is to distinguish it from a derby connector that would be used by an application to acccess data in Apache Derby.

@mandy-chessell
Copy link
Contributor Author

In addition, the getVirtualizationSolutionConnection() method in the ConnectorConfigurationFactory has hard-coded package names for the derby connector.
It should be independent of the connector implementation with the specifics passed in on the parameters.

@wyf-1116
Copy link
Contributor

Hi Mandy, I'm working on this issue. I've created a new package viewgenerator at virtualization-services-api and moved derby connector the the upper level of directory as ViewGeneratorDerbyConnector in view-generator-connectors. Is this what you suggest in the first reply? Thanks in advance for your clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants