Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary canonical model sample does not work as a utility #4662

Open
planetf1 opened this issue Feb 3, 2021 · 3 comments
Open

Glossary canonical model sample does not work as a utility #4662

planetf1 opened this issue Feb 3, 2021 · 3 comments
Labels
bug Something isn't working pinned Keep open (do not time out) samples code samples

Comments

@planetf1
Copy link
Member

planetf1 commented Feb 3, 2021

As found in #4661

Currently we provide the glossary canonical model sample in our assembly as samples//glossary-canonical-model-2.6-jar-with-dependencies.jar

The docs on how to use the parser reference an example file, and given we ship a utility one might think this would be the input parm on the tool ie:

java -jar ./glossary-canonical-model-2.6-jar-with-dependencies.jar ~/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json

Model file Name: /Users/jonesn/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json

Retrieving model contents from: /Users/jonesn/src/egeria/open-metadata-resources/open-metadata-archives/design-model-archives/glossary-canonical-model/src/test/resources/EgeriaSampleOntology.json
error is org.apache.jena.shared.NoReaderForLangException: Reader not found: JSON-LD

However this fails, since the main() used in this utility is actually in CanonicalGlossaryOwlArchiveWriter - it is not the input file for the parser. A sample of that can be found in the test code under org/odpi/openmetadata/archiveutilities/designmodels/owlcanonicalglossarymodel/TestOwlCanonicalGlossaryModelArchiveBuilder.java

As such what we have is incoherent.

We need to

  • Decide if we want to ship the utility in the distribution
  • If so, have an appropriate main that will take input from the requested jsonld file
  • Update user docs accordingly
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 11, 2021
@planetf1 planetf1 removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 12, 2021
@planetf1 planetf1 mentioned this issue Apr 29, 2021
27 tasks
@planetf1 planetf1 removed their assignment Apr 30, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jun 30, 2021
@mandy-chessell mandy-chessell removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jun 30, 2021
@planetf1 planetf1 added bug Something isn't working samples code samples labels Aug 3, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Oct 12, 2021
@planetf1 planetf1 added pinned Keep open (do not time out) and removed no-issue-activity Issues automatically marked as stale because they have not had recent activity. labels Oct 13, 2021
@davidradl davidradl removed their assignment Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned Keep open (do not time out) samples code samples
Projects
None yet
Development

No branches or pull requests

3 participants