Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot rotate log files when it reaches the max backup count #157

Closed
BluewareJ opened this issue Dec 15, 2021 · 1 comment
Closed

cannot rotate log files when it reaches the max backup count #157

BluewareJ opened this issue Dec 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@BluewareJ
Copy link

I know it's by design so far, but it may leading to infinite size of log file.
so, when it reaches the max backup file count, how about removing the the oldest backup file, and then backup current log file?
it's better to enable this behavior by passing a flag to RotatingFileHandler constructor.
how do you think? thanks.
@odygrd odygrd added the enhancement New feature or request label Apr 10, 2022
@odygrd odygrd closed this as completed in 49cf334 Apr 15, 2022
@odygrd
Copy link
Owner

odygrd commented Apr 15, 2022

this is fixed now in master, thanks for reporting ! if you have any more issues please let me know

@anluoma anluoma mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odygrd @BluewareJ