New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] formatting string with '\0' inside will cause crash #176

Closed

xywanz opened this issue May 27, 2022 · 1 comment

Labels

bug

xywanz commented May 27, 2022 •

edited

Loading

Here's the code that will crash.

#include "quill/Quill.h"
#include "fmt/format.h"

int main() {
  quill::enable_console_colours();
  quill::start();

  quill::Logger* logger = quill::get_logger();
  // construct a string with '\0' inside
  std::string msg = fmt::format("{} {} {} {} {}", (char)0, (char)0, (char)0, (char)0, "sssssssssssssssssssssss");
  QUILL_LOG_INFO(logger, "{}", msg);  // crash here
}

Although it's an incorrect usage, I think it should not cause crash.

odygrd added the bug label

odygrd closed this as completed in

b259b7f

Owner

odygrd commented May 30, 2022

hey, thanks for reporting this. It is now fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment