Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add prefix QUILL_ to log macros like LOG_INFO #40

Closed
azuresigma opened this issue Sep 1, 2020 · 3 comments
Closed

Please add prefix QUILL_ to log macros like LOG_INFO #40

azuresigma opened this issue Sep 1, 2020 · 3 comments

Comments

@azuresigma
Copy link

This is causing macro conflicts for me, as 1 of the libraries I use has the same log macro. It will be better to always have a prefix for macros like LOG_INFO, which is too easy to have a naming conflict without prefix.

Thanks a lot.

@odygrd
Copy link
Owner

odygrd commented Sep 3, 2020

hey, I don't mind doing this but since it will be a breaking change, I will provide this as an option for example you will have to #define QUILL_USE_PREFIXED_MACROS always before including Quill.h

@azuresigma
Copy link
Author

That works. Thanks a lot.

@odygrd
Copy link
Owner

odygrd commented Sep 5, 2020

Added an option to disable the non prefixed macros in 89d0986.

Can you try something like this:

#define QUILL_DISABLE_NON_PREFIXED_MACROS
#include "quill/Quill.h"

Closing for now, please let me know if you have any more issues

@odygrd odygrd closed this as completed Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants