Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs::rename throw an exception in gcc7.5.0 #230

Closed
oPiZiL opened this issue Jan 18, 2023 · 2 comments · Fixed by #231
Closed

fs::rename throw an exception in gcc7.5.0 #230

oPiZiL opened this issue Jan 18, 2023 · 2 comments · Fixed by #231
Labels
bug Something isn't working

Comments

@oPiZiL
Copy link

oPiZiL commented Jan 18, 2023

https://github.com/odygrd/quill/blob/master/quill/src/detail/misc/FileUtilities.cpp#L62
@odygrd
Copy link
Owner

odygrd commented Jan 18, 2023 •
edited
Loading

Hello, this is used in both RotatingFileHandler TimeRotatingFileHandler, which one are you using ?
Also, could you let me know the exception error please ?

Any way to reproduce it ?

@odygrd
Copy link
Owner

odygrd commented Jan 18, 2023

I think you mean that the function shouldn't be marked as noexcept, thanks for reporting this

@odygrd odygrd linked a pull request Jan 18, 2023 that will close this issue
fix rename_file throwing #231
Merged
@odygrd odygrd added the bug Something isn't working label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix rename_file throwing odygrd/quill
2 participants
@oPiZiL @odygrd