Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of colons in RPATH when building the library #284

Closed
tocic opened this issue Apr 20, 2023 · 1 comment
Closed

Lots of colons in RPATH when building the library #284

tocic opened this issue Apr 20, 2023 · 1 comment

Comments

@tocic
Copy link
Contributor

tocic commented Apr 20, 2023 •
edited
Loading

When building the library via

cmake -B "build/" -S . -DQUILL_FMT_EXTERNAL=ON -DBUILD_SHARED_LIBS=ON
cmake --build "build/" --verbose

my linker is invoked with the following options:

-Wl,-rpath,::::::::::::::

I managed to get rid of it by removing this line:

quill/quill/CMakeLists.txt

Line 114 in e42e579

set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")

Do we really need the line? I believe this directory is used for searching the libraries anyway.

Related links:
@odygrd
Copy link
Owner

odygrd commented May 13, 2023

hey and thanks, I have done that in latest master 290e360

@tocic tocic closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odygrd @tocic