Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official CSI Release Tools #18

Closed
maennchen opened this issue Apr 21, 2020 · 9 comments
Closed

Use official CSI Release Tools #18

maennchen opened this issue Apr 21, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@maennchen
Copy link
Collaborator

Use official CSI release-tools for testing / building.

@maennchen maennchen added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2020
@ofek
Copy link
Owner

ofek commented Apr 21, 2020

I'm on Windows, so I'd need it to support it. Does it? I quite like the current invoke tooling btw

@maennchen
Copy link
Collaborator Author

@ofek I would really like it at least for the E2E tests. It seems very hard to run them otherwise.

We could keep building via invoke but use it to run the tests. What do you think?

Does the driver itself work on Windows btw?

@ofek
Copy link
Owner

ofek commented Apr 21, 2020

Sure! It only works as containerized plugin, not locally (since Windows doesn't have fuse). Docker for Win/Mac provides a Linux VM that everything actually runs in

@maennchen
Copy link
Collaborator Author

@ofek How far should the Windows support go then? Only for Building the Image or also testing?

I'm asking because the official test suite including E2E contains a lot of Bash to setup a K8S Cluster correctly etc.

I like the invoke setup as well, I would prefer to stay as close to the spec & official tooling though.

@ofek
Copy link
Owner

ofek commented Apr 21, 2020

Can we run stuff in containers? Building Docker plugins doesn't work on Windows so I run dind https://hub.docker.com/_/docker

See https://github.com/ofek/docker-volume-gcs/blob/master/build.py

@maennchen
Copy link
Collaborator Author

@ofek I think we could easily do it this way:

  • Provide release tools for *NIX users (Makefile)
  • Provide a cmd/ bat / whatever we need for windows that starts all of that inside docker (dind) and calls the Makefile in there

@ofek
Copy link
Owner

ofek commented Apr 21, 2020

Sounds good, though why not just do that all the time? Seems cleaner and more reproducible for everyone imo

@maennchen
Copy link
Collaborator Author

Why not we can just expose that entrypoint script for Everyone. :)

@maennchen maennchen self-assigned this Apr 23, 2020
@maennchen maennchen added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Apr 23, 2020
@maennchen
Copy link
Collaborator Author

Setting up prow is too much work for not enough benefit for this project.

We'll instead improve the CI (#27) and setup E2E Tests (#28).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants