-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official CSI Release Tools #18
Comments
I'm on Windows, so I'd need it to support it. Does it? I quite like the current invoke tooling btw |
@ofek I would really like it at least for the E2E tests. It seems very hard to run them otherwise. We could keep building via invoke but use it to run the tests. What do you think? Does the driver itself work on Windows btw? |
Sure! It only works as containerized plugin, not locally (since Windows doesn't have fuse). Docker for Win/Mac provides a Linux VM that everything actually runs in |
@ofek How far should the Windows support go then? Only for Building the Image or also testing? I'm asking because the official test suite including E2E contains a lot of Bash to setup a K8S Cluster correctly etc. I like the invoke setup as well, I would prefer to stay as close to the spec & official tooling though. |
Can we run stuff in containers? Building Docker plugins doesn't work on Windows so I run See https://github.com/ofek/docker-volume-gcs/blob/master/build.py |
@ofek I think we could easily do it this way:
|
Sounds good, though why not just do that all the time? Seems cleaner and more reproducible for everyone imo |
Why not we can just expose that entrypoint script for Everyone. :) |
Use official CSI release-tools for testing / building.
The text was updated successfully, but these errors were encountered: