Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream - Unable to build YYC due to compiler error #371

Closed
hagusen opened this issue Jun 14, 2022 · 7 comments
Closed

Upstream - Unable to build YYC due to compiler error #371

hagusen opened this issue Jun 14, 2022 · 7 comments
Labels
bug 😅 We did a bad thing upstream bug 💧 YYG strikes again
Milestone

Comments

@hagusen
Copy link

hagusen commented Jun 14, 2022

errors from __input_config_icons.
if removed then build works fine
[it doesn't like the spaces in the names]

image

@hagusen hagusen closed this as completed Jun 14, 2022
@hagusen hagusen reopened this Jun 14, 2022
@JujuAdams JujuAdams changed the title Unable to build yyc Upstream - Unable to build YYC due to compiler error Jun 15, 2022
@JujuAdams JujuAdams added the bug 😅 We did a bad thing label Jun 15, 2022
@JujuAdams JujuAdams modified the milestones: 5.1, 5.0 Jun 15, 2022
@JujuAdams
Copy link
Collaborator

GameMaker truly is a piece of shit.

@JujuAdams JujuAdams added the upstream bug 💧 YYG strikes again label Jun 15, 2022
@JujuAdams
Copy link
Collaborator

JujuAdams commented Jun 15, 2022

No clean workaround is available for this. I have reported this issue to YYG.

@JulianDicken
Copy link

New PR isnt breaking, hope you can use it @hagusen

@offalynne
Copy link
Owner

offalynne commented Jul 23, 2022

think a suitable workaround would be to use the ‘finalize’ pattern with the INPUT_ICONS macro to do array -> struct, avoiding the stupid underscores/spaces thing.

yyc doesn’t choke on spaces in keys while running, only fails to compile when they are directly declared, so

[ ”xbox 360”, [[ “start”, “start”], […]
{ ”xbox 360” : { “start”: “start” , […]

🤔 @JujuAdams ?

@JujuAdams
Copy link
Collaborator

Alternative:

input_icons("xbox 360")
.add("gamepad face south", "A")
.add("gamepad face east",  "B")
.add("gamepad face west",  "X")
.add("gamepad face north", "Y")

@offalynne
Copy link
Owner

fluuuent. any reason to prefer the same format for keynames and blocked keys, on the subject ?

@JujuAdams
Copy link
Collaborator

Fluent interface implemented for in 5.1

Would like to stick with what we know works already for key names and blocked keys for the sake of minimising risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 😅 We did a bad thing upstream bug 💧 YYG strikes again
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants