Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp task:clear "rm -rf" on Windows #146

Open
necrower opened this issue Jul 14, 2016 · 3 comments
Open

Gulp task:clear "rm -rf" on Windows #146

necrower opened this issue Jul 14, 2016 · 3 comments

Comments

@necrower
Copy link

In line 76 in gulpfile.js the rm command does not work on windows.

childProcess.exec(rm -rf ${appConfig.releasePath} && rm -rf ${appConfig.buildPath}, next);

@PStoner3
Copy link

PStoner3 commented Sep 1, 2016

I may have a solution for this. I added some validation to the gulp file to 1) check the os environment using process.platform. Then I check if the directories exist. if both, or either, exist and the platform is win32 then I use the rmdir command to remove. otherwise I leave the original command intact.

officer, I would like for you to review. please provide next steps as this is my first foray into attempting to assist

Thank you

@jhernandezb
Copy link

Maybe using rimraf instead?

@PStoner3
Copy link

PStoner3 commented Sep 1, 2016

PR #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants