Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ugh]: Mods with a lot of unarmoured headgear or glasses (eg. USP) have extremely slow startup #3194

Closed
jaj22 opened this issue Apr 2, 2024 · 0 comments · Fixed by #3195
Closed
Labels
Performance Related to lag
Milestone

Comments

@jaj22
Copy link

jaj22 commented Apr 2, 2024

We currently add all cosmetic headgear and glasses to initial rebel equipment. However, some mods have an extremely high quantity (~14000 for USP), and the process of adding them to the arsenal is slow, because the arsenal addItem operation is a slow O(N) dependent on the size of the current arsenal tab array. Users will also be tempted to alt-tab, which makes the process another 10x slower.

If you do actually wait until the end, the arsenal times out on first attempt to open it, and appears to be showing a fraction of the hats on subsequent uses.

@jaj22 jaj22 added the Performance Related to lag label Apr 2, 2024
@jaj22 jaj22 added this to the 3.6 milestone Apr 2, 2024
@Bob-Murphy Bob-Murphy modified the milestones: 3.6, 3.5.3 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Related to lag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants