Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of bad TTData in search() when ttHit is false #5503

Open
mstembera opened this issue Jul 20, 2024 · 2 comments
Open

Use of bad TTData in search() when ttHit is false #5503

mstembera opened this issue Jul 20, 2024 · 2 comments
Labels
needs-analysis Needs further analysis

Comments

@mstembera
Copy link
Contributor

Describe the issue

As pointed out by @dubslow here #5416 (comment) and @peregrineshahin #5416 (comment) in some places search() uses values from TTData even when ttHit is false.

Expected behavior

Don't use any values from TTData when ttHit is false.

Steps to reproduce

Inspect Search::Worker::search() code.

Anything else?

No response

Operating system

All

Stockfish version

a8401e8

@peregrineshahin
Copy link
Contributor

Regarding this issue, the LTC fix passed https://tests.stockfishchess.org/tests/view/66a243b14ff211be9d4ecd4a
but I'm not able to reproduce any trigger for these two places left "unguarded" with any testing condition/long benches (multithreaded included), I'm not sure that we are using any 'bad TTData in search() when ttHit is false' as of the moment.
It probably can be explained logically, but not too sure..

@mstembera
Copy link
Contributor Author

Hmm I'm even less sure. Maybe open a PR for the fix as an RFC and see what the maintainers and others say?

@Disservin Disservin added the needs-analysis Needs further analysis label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-analysis Needs further analysis
Projects
None yet
Development

No branches or pull requests

3 participants