[FEATURE] Add selectOnClick option #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@offirgolan Thanks for the prompt answer! Testing it out right now. |
|
@offirgolan The behaviour looks exactly like what I had in mind. I'm not sure I'm the best person to do it but let me know if you also want a code review! Thanks a lot for the great support 👍 |
|
@karellm great! Np at all, I realized the change was pretty minimal so I took a stab at it. I'll make a new minor release with this later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #289.
Select a row on click. If this is set to
falseand multiSelect is enabled, using click +shift,cmd, orctrlwill still work as intended, while clicking on the row will not set the row as selected./cc @karellm. Can you please check out this branch and test it out in your app?