Move ember-cli-string-helpers to dependencies

[ynnoj]

The {{html-safe}} helper here is the cause for the PR. The string helpers in ember-composable-helpers were moved to ember-cli-string-helpers, which is why that add-on is a devDependency of ember-light-table.

I have an Ember add-on which houses a paginated table component built using ELT. ember-light-table is listed as a dependency of that add-on. Installing that add-on in my engines and consuming app results in the following error: Compile Error: html-safe is not a helper.

My fork has fixed this issue for me 🙃

[alexander-alvarez]

@ynnoj is there any background for this change?
It seems we may not even need this as we already have ember-composable-helpers as a dependency...

https://github.com/romulomachado/ember-cli-string-helpers

[ynnoj]

@alexander-alvarez I've updated the PR description ☝️

[alexander-alvarez]

yup. that makes sense.
Thanks for the headsup and clarification. I wasn't following the addon / reading closely enough...
also not a semver change 🤒. Thanks for this @ynnoj

[ynnoj]

@alexander-alvarez No problem. I'll continue to use my fork until there's a bump. Cheers!

[alexander-alvarez]

we'll try to get that out for you quick. for posterity, this was introduced only in https://github.com/offirgolan/ember-light-table/releases/tag/v1.8.5
cc @offirgolan

[offirgolan]

Released with v1.8.6. Thanks for the fix @ynnoj 😄