Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ember-truth-helpers to dependencies #390

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Move ember-truth-helpers to dependencies #390

merged 1 commit into from
Apr 25, 2017

Conversation

fsmanuel
Copy link
Contributor

I removed ember-truth-helpers from devDependencies and updated to 1.3.0.

@blimmer blimmer mentioned this pull request Apr 25, 2017
Closed
@blimmer
Copy link

blimmer commented Apr 25, 2017

This is showing up on every yarn install because of this problem:

warning ember-truth-helpers@1.2.0: The engine "ember-cli-app-version" appears to be invalid.

it'd be great to get this resolved

@alexander-alvarez alexander-alvarez merged commit 31b5ee8 into adopted-ember-addons:master Apr 25, 2017
@alexander-alvarez
Copy link
Collaborator

Thanks for this. We'll update with the fix version, when released

@fsmanuel fsmanuel deleted the chore/ember-truth-helpers branch April 25, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsmanuel @blimmer @alexander-alvarez